[no-release-notes] GMS bump #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Dec 13, 2022
Comment on lines
201
to
204
| // same for d functions | ||
| if _, ok := expr.(*dfunctions.HashOf); ok { | ||
| return nil, ErrInvalidNonLiteralArgument.New(ds.Name(), expr.String()) | ||
| } |
There was a problem hiding this comment.
any reason d functions shouldn't just implement sql.FunctionExpression?
| @@ -111,27 +110,19 @@ func TestSingleScript(t *testing.T) { | |||
| t.Skip() | |||
| var scripts = []queries.ScriptTest{ | |||
| { | |||
| Name: "trigger before update, with indexed update", | |||
There was a problem hiding this comment.
nit git checkout main -- go/libraries/doltcore/sqle/enginetest/dolt_engine_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support UnresolvedFunctions as dolt table arguments, but those functions are fuly resolved when running them prepared, so additional logic is needed to skip them.