Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use database name that is the same as directory name on disk #7020

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Nov 17, 2023

As of Dolt version 1.27.0, we allow hyphens in database name and replace space characters with underscores and reduce multiple underscore characters side by side into single underscore character.

This PR resolves:

  • Using the database name the same as directory name on disk allows round-trip to the database location on disk.

Note:

  • A potential issue might arise when the directory name has trailing space characters. MySQL do not allow database name with trailing space characters such as mydb , whereas Dolt allows. This will cause failing import of dolt dump to MySQL.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jennifersp jennifersp merged commit d09c29c into main Nov 20, 2023
17 checks passed
@jennifersp jennifersp deleted the jennifer/dbname-with-space branch November 20, 2023 21:20
@jennifersp jennifersp linked an issue Nov 20, 2023 that may be closed by this pull request
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.05 0.6
batching batch sql 10000 1 0.08 1.25
batching by line sql 10000 1 0.08 1.25
blob 1 blob 200000 1 0.89 3.13 3.56
blob 2 blobs 200000 1 0.88 4.06 4.59
blob no blob 200000 1 0.9 1.27 1.37
col type datetime 200000 1 0.78 1.82 2.01
col type varchar 200000 1 0.66 1.89 1.97
config width 2 cols 200000 1 0.76 1.29 1.37
config width 32 cols 200000 1 1.86 1.41 2.48
config width 8 cols 200000 1 0.96 1.29 1.56
pk type float 200000 1 0.84 1.21 1.25
pk type int 200000 1 0.77 1.32 1.32
pk type varchar 200000 1 1.48 1.01 0.98
row count 1.6mm 1600000 1 5.58 1.5 1.54
row count 400k 400000 1 1.4 1.5 1.5
row count 800k 800000 1 2.77 1.48 1.53
secondary index four index 200000 1 3.54 1.12 1.04
secondary index no secondary 200000 1 0.86 1.33 1.44
secondary index one index 200000 1 1.08 1.52 1.55
secondary index two index 200000 1 1.91 1.29 1.17
sorting shuffled 1mm 1000000 0 5.03 1.84 1.84
sorting sorted 1mm 1000000 1 5.19 1.79 1.77

Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.28
dolt_blame_commit_filter system table 2.84
dolt_commit_ancestors_commit_filter system table 0.9
dolt_commits_commit_filter system table 0.9
dolt_diff_log_join_from_commit system table 1.64
dolt_diff_log_join_to_commit system table 1.6
dolt_diff_table_from_commit_filter system table 1.13
dolt_diff_table_to_commit_filter system table 1.11
dolt_diffs_commit_filter system table 1.06
dolt_history_commit_filter system table 1.23
dolt_log_commit_filter system table 0.97

Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.72
adds_updates_deletes 60000 60000 60000 3.92
deletes_only 0 60000 0 1.87
updates_only 0 0 60000 2.53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stop renaming database names with blank spaces
2 participants