Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stats]: fix panic for empty table stats with one root chunk #7507

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

max-hoffman
Copy link
Contributor

There's one root chunk for an empty table that needs special handling because there is no histogram bucket for it.

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
99.999562 to 99.999562
version result total
732127d not ok 26
732127d ok 5937431
version total_tests
732127d 5937457
correctness_percentage
99.999562

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
99.999562 to 99.999562
version result total
9649a5b not ok 26
9649a5b ok 5937431
version total_tests
9649a5b 5937457
correctness_percentage
99.999562

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
99.999562 to 99.999562
version result total
aace986 not ok 26
aace986 ok 5937431
version total_tests
aace986 5937457
correctness_percentage
99.999562

@max-hoffman max-hoffman merged commit 2fbcb38 into main Feb 26, 2024
19 of 20 checks passed
@max-hoffman max-hoffman deleted the max/empty-stats-bugs branch February 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants