Skip to content

Commit

Permalink
unskip tests
Browse files Browse the repository at this point in the history
  • Loading branch information
liuliu-dev committed Oct 10, 2024
1 parent 6b5e3f0 commit 4e13547
Show file tree
Hide file tree
Showing 27 changed files with 39 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe(`${pageName} renders expected components on different devices`, () => {
),
];

const skip = true;
const skip = false;
const devices = [macbook15ForAppLayout(pageName, tests, false, loggedIn)];
runTestsForDevices({ currentPage, devices, skip, loggedIn });
});
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ describe(`${pageName} expected components on different devices`, () => {
const tests = [...testDeployHosted, ...testDeploySelfHosted];

const devices = [macbook15ForAppLayout(pageName, tests, false, loggedIn)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip, loggedIn });
});
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@ describe(`${pageName} renders expected components on different devices`, () => {

const devices = [macbook15ForAppLayout(pageName, tests, false, loggedIn)];

const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip, loggedIn });
});
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];
const loggedIn = true;
const devices = [macbook15ForAppLayout(pageName, tests, false, loggedIn)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip, loggedIn });
});
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests, false, loggedIn)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip, loggedIn });
});
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests, false, loggedIn)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip, loggedIn });
});
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests, false, loggedIn)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip, loggedIn });
});
28 changes: 13 additions & 15 deletions cypress/e2e/dolthub/publicPaths/api/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const selectQuery = "SELECT * FROM `places` ORDER BY place_id ASC LIMIT 5;";
const badQuery = "heatdome";

describe("API returns 404 for invalid endpoints", () => {
xit("gets 404 responses from non-existent endpoints", () => {
it("gets 404 responses from non-existent endpoints", () => {
cy.request({
url: `/api/`,
failOnStatusCode: false,
Expand All @@ -32,10 +32,10 @@ describe("API returns 404 for invalid endpoints", () => {

describe(`API returns query results for '${defaultQuery}' from ${defaultBranch} without branch or query specified`, () => {
const earl = `/api/${apiVersion}/${repoOwner}/${repoName}`;
xit("gets a success response from the API", () => {
it("gets a success response from the API", () => {
cy.request({ url: earl }).its("status").should("equal", 200);
});
xit("contains the correct query metadata in the response body", () => {
it("contains the correct query metadata in the response body", () => {
cy.request({ url: earl })
.its("body.sql_query")
.should("equal", `${defaultQuery}`);
Expand All @@ -55,7 +55,7 @@ describe(`API returns query results for '${defaultQuery}' from ${defaultBranch}
.its("body.query_execution_message")
.should("equal", "");
});
xit("contains the correct query result schema in the response body", () => {
it("contains the correct query result schema in the response body", () => {
cy.request({ url: earl })
.its("body.schema")
.should("deep.equal", [
Expand All @@ -65,7 +65,6 @@ describe(`API returns query results for '${defaultQuery}' from ${defaultBranch}
},
]);
});

it("contains the correct query result rows in the response body", () => {
cy.request({ url: earl })
.its("body.rows")
Expand Down Expand Up @@ -102,10 +101,10 @@ describe(`API returns query results for '${defaultQuery}' from ${defaultBranch}

describe(`API returns query results for '${defaultQuery}' from branch ${otherBranch} without query specified`, () => {
const earl = `/api/${apiVersion}/${repoOwner}/${repoName}/${otherBranch}`;
xit("gets a success response from the API", () => {
it("gets a success response from the API", () => {
cy.request({ url: earl }).its("status").should("equal", 200);
});
xit("contains the correct query metadata in the response body", () => {
it("contains the correct query metadata in the response body", () => {
cy.request({ url: earl })
.its("body.sql_query")
.should("equal", `${defaultQuery}`);
Expand All @@ -125,7 +124,7 @@ describe(`API returns query results for '${defaultQuery}' from branch ${otherBra
.its("body.query_execution_message")
.should("equal", "");
});
xit("contains the correct query result schema in the response body", () => {
it("contains the correct query result schema in the response body", () => {
cy.request({ url: earl })
.its("body.schema")
.should("deep.equal", [
Expand All @@ -135,7 +134,7 @@ describe(`API returns query results for '${defaultQuery}' from branch ${otherBra
},
]);
});
xit("contains the correct query result rows in the response body", () => {
it("contains the correct query result rows in the response body", () => {
cy.request({ url: earl })
.its("body.rows")
.should("deep.equal", [
Expand Down Expand Up @@ -173,10 +172,10 @@ describe(`API returns query results for '${selectQuery}' from ${defaultBranch} w
const earl = `/api/${apiVersion}/${repoOwner}/${repoName}?q=${encodeURI(
selectQuery,
)}`;
xit("gets a success response from the API", () => {
it("gets a success response from the API", () => {
cy.request({ url: earl }).its("status").should("equal", 200);
});
xit("contains the correct query metadata in the response body", () => {
it("contains the correct query metadata in the response body", () => {
cy.request({ url: earl })
.its("body.sql_query")
.should("equal", `${selectQuery}`);
Expand All @@ -196,7 +195,7 @@ describe(`API returns query results for '${selectQuery}' from ${defaultBranch} w
.its("body.query_execution_message")
.should("equal", "");
});
xit("contains the correct query result schema in the response body", () => {
it("contains the correct query result schema in the response body", () => {
cy.request({ url: earl })
.its("body.schema")
.should("deep.equal", [
Expand All @@ -222,7 +221,6 @@ describe(`API returns query results for '${selectQuery}' from ${defaultBranch} w
},
]);
});

it("contains the correct query result rows in the response body", () => {
cy.request({ url: earl })
.its("body.rows")
Expand Down Expand Up @@ -270,10 +268,10 @@ describe(`API returns query error for invalid query '${badQuery}'`, () => {
const earl = `/api/${apiVersion}/${repoOwner}/${repoName}?q=${encodeURI(
badQuery,
)}`;
xit("gets a success response from the API", () => {
it("gets a success response from the API", () => {
cy.request({ url: earl }).its("status").should("equal", 200);
});
xit("contains the correct query metadata in the response body", () => {
it("contains the correct query metadata in the response body", () => {
cy.request({ url: earl })
.its("body.sql_query")
.should("equal", `${badQuery}`);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe(`${pageName} renders expected components on different devices`, () => {
const devices = [
macbook15ForAppLayout(pageName, changeBranch(changeBranchParams)),
];
const skip = true;
const skip = false;
runTestsForDevices({
currentPage: `${currentPage}${currentBranch}`,
devices,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
iPad2ForAppLayout(pageName, tests),
iPhoneXForAppLayout(pageName, mobileTests),
];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
};

const devices = [macbook15ForAppLayout(pageName, changeBranch(testParams))];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests())];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
iPad2ForAppLayout(pageName, tests),
iPhoneXForAppLayout(pageName, mobileTests),
];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ describe(`${pageName} expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ describe(`${pageName} renders expected component on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,6 @@ describe(`${pageName} renders expected component on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ describe(`${pageName} renders expected components on different devices`, () => {
),
),
];
const skip = true;
const skip = false;
runTestsForDevices({
currentPage: `${currentPage}${currentBranch}`,
devices,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const currentPage = `repositories/${currentOwner}/${currentRepo}/pulls/${current
const destinationBranch = "master";

// Need to investigate why the tests for this page are flaky
const skip = true;
const skip = false;

describe(`${pageName} renders expected components on different devices`, () => {
const beVisible = newShouldArgs("be.visible");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const currentRepo = "corona-virus";
const currentPullId = isProd ? "5" : "1";
const currentPage = `repositories/${currentOwner}/${currentRepo}/pulls/${currentPullId}/compare`;

const skip = true;
const skip = false;

describe(`${pageName} renders expected components on different devices`, () => {
const beVisible = newShouldArgs("be.visible");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const currentPage = `repositories/${currentOwner}/${currentRepo}/pulls/${current

describe(`${pageName} renders expected components on different devices`, () => {
const beVisible = newShouldArgs("be.visible");
const skipAll = true;
const skipAll = false;

const tests = [
newExpectation(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
2 changes: 1 addition & 1 deletion cypress/e2e/dolthub/publicPaths/render/pulls/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
),
),
];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
];

const devices = [macbook15ForAppLayout(pageName, tests)];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ describe(`${pageName} renders expected components on different devices`, () => {
),
),
];
const skip = true;
const skip = false;
runTestsForDevices({ currentPage, devices, skip });
});

0 comments on commit 4e13547

Please sign in to comment.