Moving transaction initialization before query analysis #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to before invoking analyzer.
…sactions if any errors occur while executing a query.
…r automatic transaction management (not for explicitly created transactions).
…ql-server into fulghum/dolt-3402
fulghum
commented
May 16, 2022
| // don't need to do anything here to clear implicit transaction state. | ||
| // | ||
| // TODO: This logic would probably read more clearly if we could just ask the session/ctx if the | ||
| // current transaction is automatically created or explicitly created by the caller. |
There was a problem hiding this comment.
I considered adding something to Session or Transaction's interface to show whether the current transaction is automatically created by the system (i.e. autocommit) or is explicitly requested by the client, but wanted to keep this fix as small as possible. I think the code that needs to use GetIgnoreAutoCommit would read a little clearer with that refactor, so happy to follow up with that if you think it's worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves transaction creation ahead of query analysis, so that queries can be executed with the latest committed state from other transactions.
Fixes: dolthub/dolt#3402