Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize IndexedTableAccess on DoltDiff tables #1037

Merged
merged 10 commits into from
Jun 4, 2022

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Jun 2, 2022

No description provided.

@jycor jycor changed the title indexed table access implements sql.Table and is parallelizable Parallelize IndexedTableAccess on DoltDiff tables Jun 2, 2022
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but tests belong in dolt, not in this pacakge

@@ -265,6 +265,16 @@ func TestQueryPlans(t *testing.T, harness Harness) {
}
}

// TestDoltDiffQueryPlans only works on Dolt
func TestDoltDiffQueryPlans(t *testing.T, harness Harness) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to only be defined in dolt, not in the general engine tests

@jycor jycor merged commit f302c01 into main Jun 4, 2022
@Hydrocharged Hydrocharged deleted the james/exchange-indexed-access branch October 13, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants