Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] sql/{analyzer,plan}: Be a bit more deliberate about where we use NullSafeEquals vs Equals in index search expressions. #1070

Merged
merged 1 commit into from
Jun 21, 2022
Merged

[no-release-notes] sql/{analyzer,plan}: Be a bit more deliberate about where we use NullSafeEquals vs Equals in index search expressions. #1070

merged 1 commit into from
Jun 21, 2022

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Jun 21, 2022

No description provided.

@reltuk
sql/{analyzer,plan}: Be a bit more deliberate about where we use Null…
da1069e 
…SafeEquals vs Equals in index search expressions.
zachmu
zachmu approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but should have tests for these

@reltuk reltuk merged commit 81f0c07 into main Jun 21, 2022
reltuk added a commit that referenced this pull request Jun 21, 2022
@reltuk
Revert "Merge pull request #1070 from dolthub/aaron/null-safe-equals-…
00f1fdb 
…in-index-search"

This reverts commit 81f0c07, reversing
changes made to 360a341.
reltuk added a commit that referenced this pull request Jun 21, 2022
@reltuk
Merge pull request #1071 from dolthub/aaron/revert-null-index-changes
a13a7c4 
Revert #1070 and #1067. Needs more testing and some edge cases considered.
@Hydrocharged Hydrocharged deleted the aaron/null-safe-equals-in-index-search branch October 13, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reltuk @zachmu