Improve how index lookups and ranges address NULL values. #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake it participate in the Range machinery.
Print lower bound AboveAll as (∞. Make IsEmpty return true is Lower >= Upper. Make RangeTree.GetRangeCollection() merge adjacent ranges on return. Make IndexBuilder exclude superfluous empty ranges.
…ilding static lookups that can actually match NULL.
andy-wm-arthur
approved these changes
Jun 24, 2022
| rangeColumnExpr = expression.NewNullSafeLessThan(idx.Exprs[i], expression.NewLiteral(lit, typ)) | ||
| rangeColumnExpr = or( | ||
| expression.NewLessThan(idx.Exprs[i], expression.NewLiteral(lit, typ)), | ||
| expression.NewIsNull(idx.Exprs[i]), |
There was a problem hiding this comment.
select * from t where c0 < 3 does not return nulls, so I'm assuming it doesn't get translated to a RangeType_LessThan
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestIndexBuilderRanges(t *testing.T) { |
There was a problem hiding this comment.
you should add a LT4=(NULL,4)
| return RangeColumnExpr{ | ||
| BelowAll{}, | ||
| AboveNull{}, |
…they include NULL.
…on = do not scan NULL entries.
…-null' into aaron/sql-ranges-add-above-below-null
…anges-add-above-below-null-2
…w-null-2 sql/analyzer: Make indexed joins more aware of NULL safe comparisons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.