Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust limits on varbinary/json data #1099

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Adjust limits on varbinary/json data #1099

merged 3 commits into from
Jul 5, 2022

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jul 5, 2022 •
edited
Loading

  • Relaxed limit on incoming varbinary fields to allow for large JSON fields, which have a max size of 1GB and come across the wire as varbinary types.
  • Added a test to ensure limits on varbinary fields are still being honored.
  • Added a size limit on JSON fields at 1GB.

Fixes: dolthub/dolt#3728

@fulghum fulghum marked this pull request as ready for review July 5, 2022 19:50
andy-wm-arthur
andy-wm-arthur approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

enginetest/queries/json_scripts.go Show resolved Hide resolved
@fulghum
Adding a new test case with JSON data larger than VARCHAR/VARBINARY's…
bb7a269 
… 65k limit, but smaller than JSON's 1GB limit.
@fulghum fulghum merged commit 03e02e6 into main Jul 5, 2022
@Hydrocharged Hydrocharged deleted the fulghum/issue-3728 branch October 13, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-wm-arthur andy-wm-arthur andy-wm-arthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prepare binding failed when fields length more than 65535
2 participants
@fulghum @andy-wm-arthur