Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init RO sess vars #1113

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Init RO sess vars #1113

merged 4 commits into from
Jul 11, 2022

Conversation

bheni
Copy link
Contributor

@bheni bheni commented Jul 11, 2022

I needed a way to initialize read-only session variables so I can set them when a new user connects to a value that depends on which user connects.

@bheni bheni requested a review from max-hoffman July 11, 2022 21:00
@bheni bheni changed the title Init ro sess vars Init RO sess vars Jul 11, 2022
max-hoffman
max-hoffman approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @zachmu might have opinions

@bheni bheni merged commit b3d56e3 into main Jul 11, 2022
@bheni bheni deleted the bh/init-ro-sess-vars branch July 11, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bheni @max-hoffman