Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error message when a stored procedure isn't found and no DB is selected #1138

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jul 28, 2022

Previously, if a user tried to call a stored procedure with no database selected, they would get this error message:

stored procedure "%s" does not exist

We've seen some users connect to a sql-server, but not use a database and be confused by this error message, so this change adds extra content to the error message when no current database is selected:

stored procedure "%s" does not exist: this might be because no database is selected

@fulghum fulghum requested a review from max-hoffman July 28, 2022 22:08
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. small nits

sql/analyzer/stored_procedures.go Outdated Show resolved Hide resolved
@fulghum fulghum merged commit 3625099 into main Jul 28, 2022
@Hydrocharged Hydrocharged deleted the fulghum/stored-proc-error-message branch October 13, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants