Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1 % 0 should not panic but return NULL #1221

Merged
merged 1 commit into from
Aug 26, 2022
Merged

1 % 0 should not panic but return NULL #1221

merged 1 commit into from
Aug 26, 2022

Conversation

druvv
Copy link
Contributor

@druvv druvv commented Aug 26, 2022 •
edited
Loading

@druvv druvv requested review from jycor and removed request for jycor August 26, 2022 18:32
fulghum
fulghum approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice fix.

@druvv druvv merged commit 6352481 into main Aug 26, 2022
@Hydrocharged Hydrocharged deleted the dhruv/fix-panic-on-mod-0 branch August 30, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@druvv @fulghum