feat:(sql function) support last_insert_id with expr #1248
Conversation
mysql support parameter for LAST_INSERT_ID(expr), it is useful in upsert query when we want to get the updated recored id ref: https://dev.mysql.com/doc/refman/8.0/en/information-functions.html#function_last-insert-id
There was a problem hiding this comment.
Hey @xujihui1985, thanks for sending us this contribution! 🙏
The code looks good; I just had one small suggestion for reusing some existing int conversion code.
I think the last thing we need it getting some test coverage. There are already some tests for last_update_id() in script_queries.go that should be pretty easy to extend.
1. use sql.Int64.Convert instead of duplicate toInt64 2. add test to improve converage
There was a problem hiding this comment.
Hey @xujihui1985, thank you for this contribution! Awesome to have support for expressions passed to the last_insert_id function. 🎉 Thank you! 🙏
Your code changes look great. I found two very small edits to get the CI tests passing, so I went ahead and applied them for you. I'm approving and will merge this one into main.
Thanks, this my pleasure to have contribution to this project. |
mysql support parameter for LAST_INSERT_ID(expr), it is useful in upsert query when we want to get the updated recored id
ref: https://dev.mysql.com/doc/refman/8.0/en/information-functions.html#function_last-insert-id