Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test ordering #1273

Merged
merged 1 commit into from
Sep 20, 2022
Merged

fix test ordering #1273

merged 1 commit into from
Sep 20, 2022

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Sep 20, 2022 •
edited
Loading

some tests on dolt were failing for JSON_TABLES, due to abiguous ORDER BY
Companion PR: dolthub/dolt#4355

zachmu
zachmu approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jycor jycor merged commit 54ce417 into main Sep 20, 2022
@Hydrocharged Hydrocharged deleted the james/json_table branch October 13, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @zachmu