More join types #1280
Merged
More join types #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Sep 27, 2022
sql/analyzer/hoist_select_exists.go
Outdated
| }) | ||
| } | ||
|
|
||
| // pluckCorrelatedExistsSubquery scans a filter for [note] WHERE EXISTS, and then attempts to |
There was a problem hiding this comment.
autocorrect i think, meant [NOT] WHERE EXISTS
sql/plan/join.go
Outdated
| type JoinType uint16 | ||
|
|
||
| const ( | ||
| UnknownJoinType JoinType = iota // UnknownJoinType |
There was a problem hiding this comment.
nit: generally speaking we name this kind of enum constant with the type first, so that all the possible values sort next to eachother
| BinaryNode | ||
| Cond sql.Expression | ||
| Filter sql.Expression |
There was a problem hiding this comment.
Prefer cond, is there a particular reason you changed this?
There was a problem hiding this comment.
filters are more mobile in the new join ordering algo, seems easier to just call them all filters. At some point i'd like to split these into a list of filters rather than an expression.JoinAnd(filters...), probably memoized, index selection doesn't have to be as painful as it is right now.
| panic("join implementation should provide schema") | ||
| } | ||
|
|
||
| func constructNewJoin(base *joinBase) JoinNode { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
FullOuterJoin,SemiJoin, andAntiJoin.None of these new join nodes are safe for join ordering transformations yet. They are explicitly excluded from join planning.
The getField indexes for these three nodes' join conditions deserve more consideration. I excluded them from auto-fixup after manually correcting join condition get fields for the appropriate schemas.
FullOuterJoinuses a union distinct execution operator, which is correct but a lot slower than a merge join-esque operator.SemiJoinandAntiJoinrearrange subquery expression scopes. I separateresolveandfinalizeSubqueryExpressionsto perform decorrelation before predicate pushdown (where we were panicking on FixUpExpressions) and join ordering (we want to decorrelate scopes before join planning).Other: