Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for GeometryCollection pt. 1 #1332

Merged
merged 36 commits into from
Oct 18, 2022
Merged

add support for GeometryCollection pt. 1 #1332

merged 36 commits into from
Oct 18, 2022

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Oct 13, 2022 •
edited
Loading

Part 8 of fix for: dolthub/dolt#3638

Changes:

  • have the deserialize data and write data methods return their own byte counts, to more easily track where we are in main deserailizer
  • adding GeometryCollection type
  • these functions now work with GeometryCollection
    • GeometryCollection
    • GeomCollection
    • st_aswkb
    • st_geometrycollectionfromwkb
    • st_geomcollfromwkb

@jycor jycor changed the base branch from main to james/mpoly3 October 13, 2022 17:45
@jycor jycor changed the base branch from james/mpoly3 to main October 14, 2022 06:40
jycor and others added 3 commits October 18, 2022 11:47
@jycor jycor merged commit 3e6ea0f into main Oct 18, 2022
@Hydrocharged Hydrocharged deleted the james/geomcoll branch March 29, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-wm-arthur andy-wm-arthur andy-wm-arthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @andy-wm-arthur