Add support for database collations #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hydrocharged
force-pushed
the
daylon/db-collation
branch
2 times, most recently
from
77d2be9
to
74be833
Compare
andy-wm-arthur
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
LGTM!
@zachmu might have some opinions on the new interface in core.go, but it seems straight forward.
Hydrocharged
force-pushed
the
daylon/db-collation
branch
2 times, most recently
from
c09a0d3
to
16ca421
Compare
Hydrocharged
force-pushed
the
daylon/db-collation
branch
from
16ca421
to
6c36bfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting the database collation, such that all newly created tables within a database (that do not explicitly set their collation) will inherit the database collation.
Builds on dolthub/vitess#199