Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for sql type Zero() functions #1356

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

druvv
Copy link
Contributor

@druvv druvv commented Oct 28, 2022

Implementers of GMS might expect similar values to be returned by Convert() and Zero(). For decimal and enum implementations this was not the case and has been fixed.

Implementers of GMS might expect similar values to be returned by Convert() and Zero(). For decimal and enum implementations this was not the case.
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@druvv druvv merged commit 938ee5a into main Nov 1, 2022
@jennifersp jennifersp deleted the dhruv/fix-ignore-panic branch November 3, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants