Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend rows for only projector nodes #1379

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

jennifersp
Copy link
Contributor

This PR was reverted but now it has fixed tests that passes for dolt engine tests. The table is keyless table, which causes output result to be in randomized order in dolt compared to gms, so the tests now include order by clauses to persist the order of the output rows.

@jennifersp jennifersp requested a review from druvv November 4, 2022 16:54
Copy link
Contributor

@druvv druvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you

@jennifersp jennifersp merged commit 864be8c into main Nov 4, 2022
@jennifersp jennifersp deleted the jennifer/projector branch November 4, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IN predicate returns wrong results when used with GROUP BY ... HAVING subquery
2 participants