Fix for commutative join types getting stuck in analysis loop #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… why HashLookup/CachedResults nodes are missing
max-hoffman
requested changes
Nov 18, 2022
…sions in expression groups.
…each subquery and runs from the bottom of the tree up.
|
@max-hoffman – this one is ready for another look now that the |
max-hoffman
approved these changes
Nov 23, 2022
| return finalizeSubqueriesHelper(ctx, a, n, scope, sel) | ||
| } | ||
|
|
||
| // finalizeSubqueriesHelper recurses through the specified |node| to find all leaf subqueries and subquery expressions, |
There was a problem hiding this comment.
one confusing thing is that the traversal connectivity crosses some scope boundaries, but not others. I think it still works? for example subqueries in unions, windows, or insert sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where the analyzer can get stuck in a loop bouncing back and forth between the original and commuted plan and being unable to stabilize the plan.
As part of that fix... it also deduplicates logically identical
relExprs inexprGroups and changes thefinalizeSubqueriesanalyzer rule so that it only runs once on each subquery, from the bottom of the plan tree, up.Fixes: dolthub/dolt#4816
Dolt Tests: dolthub/dolt#4859