add uptime
#1422
Merged
add uptime
#1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Nice! I think this is fine.
For testing, you could just call SHOW GLOBAL STATUS LIKE 'Uptime'; and assert that the result is a non negative integer. Probably can't use a ScriptTestAssertion though, since you don't know the exact value ahead of time though, and I can't think of a way to modify that restricted query to make it work in one like we could with a more flexible select statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not quite sure how to test or if it's the best way to have system variables that dynamically update...
fix for: dolthub/dolt#4473