Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests for non-unique indexes over keyless tables #1425

Merged
merged 1 commit into from
Nov 28, 2022
Merged

tests for non-unique indexes over keyless tables #1425

merged 1 commit into from
Nov 28, 2022

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Nov 28, 2022 •
edited
Loading

Non-unique indexes work as expected for in-memory tables, but there were no tests.

companion pr: dolthub/dolt#4873
tests for: dolthub/dolt#4861

@jycor jycor mentioned this pull request Nov 28, 2022
Merged
fulghum
fulghum approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🚢

@jycor jycor merged commit 62e11be into main Nov 28, 2022
@Hydrocharged Hydrocharged deleted the james/index branch March 29, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @fulghum