binlog replication interface between GMS and Dolt #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccess the engine to start the binlog replication process
…ch, to pick up replication statement support.
…ch, to pick up replication statement support.
…ation coordination
…ub/go-mysql-server into fulghum/binlog-replication
…lementing the BinlogReplicaControllerCommand interface.
… REPLICA statements.
…filtering info in 'SHOW REPLICA STATUS'
zachmu
approved these changes
Jan 20, 2023
…ule, instead of directly in the engine code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
BinlogReplicaControllerinterface that defines how GMS interacts with the binlog replication code in Dolt when a user enters a replication SQL command, such asCHANGE REPLICATION SOURCE TO ...,START REPLICA, etc.The biggest remaining TODO in this code is adding support for
CheckPrivilegesfunctions.In the future, we may want to refactor out the generic binlog replication code to GMS and keep the Dolt/storage specific components in Dolt with a more detailed interface, but that felt like overkill for the initial binlog implementation.