Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the remaining statements for stored procedures #1517

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Added the remaining statements for stored procedures #1517

merged 1 commit into from
Jan 6, 2023

Conversation

Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Jan 5, 2023 •
edited
Loading

Also added labels to BEGIN...END blocks, which were missing.

fulghum
fulghum approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor questions/suggestions.

sql/plan/while.go Outdated Show resolved Hide resolved
sql/plan/while.go Outdated Show resolved Hide resolved
sql/plan/loop.go Outdated Show resolved Hide resolved
sql/plan/case.go Outdated Show resolved Hide resolved
sql/plan/loop.go Show resolved Hide resolved
sql/plan/case.go Outdated Show resolved Hide resolved
sql/plan/begin_end_block.go Show resolved Hide resolved
enginetest/queries/procedure_queries.go Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 7a841f3 into main Jan 6, 2023
@Hydrocharged Hydrocharged deleted the daylon/sp-last-statements branch January 6, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @fulghum