fix expression round trip bug #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mysql-server into max/sclar-expr-str-roundtrip
zachmu
approved these changes
Jan 26, 2023
| children := []string{hit.Left().String(), hit.Right().String()} | ||
| _ = pr.WriteChildren(children...) | ||
| return pr.String() | ||
| return fmt.Sprintf("(%s HASH IN %s)", hit.Left(), hit.Right()) |
There was a problem hiding this comment.
This one you can leave alone if you want, it should never show up in something like show create table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalar expressions need to round-trip for CHECK constraints, which expect to re-parse what they serialize with
String().