Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varchars don't error for failed IN cast to smaller varchar #1562

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

max-hoffman
Copy link
Contributor

This does not address conversions between strings and non-string types, and type casting for index lookups, which look somewhat more complex in mysql.

@max-hoffman max-hoffman changed the title Varchars don't error for failed in cast to smaller varchar Varchars don't error for failed IN cast to smaller varchar Jan 27, 2023
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@max-hoffman max-hoffman merged commit 4fe72de into main Jan 28, 2023
@max-hoffman max-hoffman deleted the max/in-subquery-varchar-casting branch January 28, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants