Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enginetest: Small cleanup for DROP DATABASE and DROP TABLE tests to be a little more hygienic in their use of state across the tests. #1600

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Feb 17, 2023

No description provided.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


_, ok, err := db.GetTableInsensitive(ctx, "mytable")
require.True(ok)
func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this one in a t.run too?

@reltuk reltuk merged commit 09205e0 into main Feb 17, 2023
@Hydrocharged Hydrocharged deleted the aaron/enginetests-drop-cleanup branch March 29, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants