update separator parsing in group_concat #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephkyou
force-pushed
the
steph/dolt-5570
branch
from
aed792d
to
29f92ce
Compare
stephkyou
force-pushed
the
steph/dolt-5570
branch
from
11ce492
to
8fbebfa
Compare
stephkyou
requested review from
fulghum and
zachmu
and removed request for
fulghum
zachmu
reviewed
Apr 4, 2023
There was a problem hiding this comment.
Rather than push sqlparser struct into the GroupConcat expression implementation, follow the same pattern used elsewhere: in parse.go, translate the sqlparser version of the AST into a string and give it to the GroupConcat expression. Isolate the concern of understanding sqlparser's version of the AST to the boundary layer, which is parse.go. parse.go's job is to turn that representation into one used by GMS, which should be a simple separator string (which could be the empty string), which is always printed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates separator parsing for group_concat to use new
Separatorstruct. This change is needed to allow''as a separator.fixes: dolthub/dolt#5570
related: dolthub/vitess#230