Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update stored procedure timestamps to be accurate #1711

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

stephkyou
Copy link
Contributor

@stephkyou stephkyou commented Apr 13, 2023

Currently when we load non-built-in stored procedures, we re-analyze the sql string which also re-creates all the metadata. This means that the Created At and Modified At fields can re-set every time the procedure is loaded in, instead of showing the correct timestamp. This change updates the loaded in procedure with the correct timestamps.

fixes: dolthub/dolt#3081

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@stephkyou stephkyou merged commit 0cd7a98 into main Apr 13, 2023
@stephkyou stephkyou deleted the steph/dolt-3081 branch April 13, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SHOW PROCEDURE STATUS is always current time
2 participants