Use SO_REUSEADDR and SO_REUSEPORT options when creating the sql server on Unix #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktobey
force-pushed
the
nicktobey/sql-server
branch
from
11184af
to
9204dc5
Compare
fulghum
approved these changes
Jun 16, 2023
| Control: func(network, address string, c syscall.RawConn) error { | ||
| var socketErr error | ||
| err := c.Control(func(fd uintptr) { | ||
| err := unix.SetsockoptInt(int(fd), unix.SOL_SOCKET, unix.SO_REUSEADDR, 1) |
There was a problem hiding this comment.
(minor) Would be nice to leave a short one sentence comment in here quickly explaining the intent of this. Would be helpful for future code readers who find this and aren't sure why it's needed. (More helpful to explain the issue we were seeing with port reuse and the hypothesis about TIME_WAIT than just rehashing what the options do, since that's easy to look up.)
nicktobey
force-pushed
the
nicktobey/sql-server
branch
from
0aba648
to
6a17104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a transient error we've been seeing where the server sometimes fails to start, and the OS claims
port already in use, even though we've already confirmed that the port is not in use prior to runningdolt sql-server.