Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic for group by binary type #1844

Merged
merged 4 commits into from
Jun 22, 2023
Merged

fix panic for group by binary type #1844

merged 4 commits into from
Jun 22, 2023

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Jun 21, 2023

We made a bad type assertion for sql.StringType.
Additionally, this fixes a issue where UnaryExpressions with GetFields would incorrectly throw a functional dependency error with ONLY_FULL_GROUP_BY enabled.

Fix for second part of: dolthub/dolt#6179

max-hoffman
max-hoffman approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple flags for suspicious things. need better aggregation testing and validation but this isn't the place to do it

sql/analyzer/validation_rules.go Outdated Show resolved Hide resolved
sql/rowexec/agg.go Show resolved Hide resolved
@jycor jycor merged commit 715b6fd into main Jun 22, 2023
@jycor jycor deleted the james/gb branch July 21, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @max-hoffman