leave aliases in projection #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
reviewed
Aug 17, 2023
| @@ -1124,7 +1124,22 @@ Select * from ( | |||
| { | |||
| Query: `select y, (select 1 from uv where y = 1 and u = x) is_one from xy join uv on x = v order by y;`, | |||
| ExpectedPlan: "Project\n" + | |||
| " ├─ columns: [xy.y:1, is_one:4]\n" + | |||
| " ├─ columns: [xy.y:1, Subquery\n" + | |||
There was a problem hiding this comment.
i'm kind of surprised this doesn't break sometimes. i intentionally separate subquery expressions from their inputs so that correlated subqueries get their inputs. i guess if we stack them deep enough the subqueries still get their inputs. either way this isn't ideal, we need lateral joins to avoid the duplicate exec and naming trade-offs
max-hoffman
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We convert
expression.Aliasintoexpression.GetFieldwith the name replaced in the top-level projection.When aliasing two different columns with the same name, we fail to properly distinguish them and end up rewriting the GetField indexes for both columns to be the same; this leads to incorrect results.
A simple fix appears to be simply allowing the top-level projection to remain as an
expression.Alias.This fix does not work for prepared statements in the old name resolution path.
fix for: dolthub/dolt#6455