Simplify projections #1936
Closed
Simplify projections #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated stored columns prototype
zachmu
reviewed
Aug 15, 2023
| // of optimizations local to this specific node. Eventually there should be a | ||
| // top level optimizer with a switch for every type. | ||
|
|
||
| func factoryBuildProject(p *plan.Project) (sql.Node, error) { |
There was a problem hiding this comment.
you want me to just make it factory.BuildProject to start with? splitting it off into a package seemed premature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View into an add-on feature to name resolution. Not intended for merging.
This is an example of a simplification rule that optimizes a node before it is added to a plan. In this case, we are deduplicating projection nodes at a point when we have the most tagging metadata about expression ids. We do not remove projections when a subquery expression backreferences an alias in the same scope. This will revert many of the extra projections in the earlier PRs.