Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lateral join uses prepend row on RHS #1954

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Lateral join uses prepend row on RHS #1954

merged 2 commits into from
Aug 21, 2023

Conversation

max-hoffman
Copy link
Contributor

No description provided.

@max-hoffman max-hoffman requested a review from jycor August 19, 2023 00:12
jycor
jycor approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense to prepend instead of a special member variable for Filter nodes.

@max-hoffman max-hoffman merged commit 5d3d97c into main Aug 21, 2023
6 checks passed
@max-hoffman max-hoffman deleted the max/lateral-join-fixes branch August 21, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-hoffman @jycor