Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memo/planbuilder: Off by one error, and issue importing statistics for testing #2327

Merged
merged 11 commits into from
Feb 20, 2024

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Feb 14, 2024

The original bug was a one-off error where conjCollector was checking for the wrong equivalence column. That spiraled into:

  • statistics were not properly being used for some tests because PRIMARY case sensitivity in ANALYZE ... UPDATE HISTOGRAM statements
  • one integration test had a weird edge case where OSX and linux compute slightly differently float values, leading to different plans locally vs CI. One option was to truncate the specificity of all cost values with a multiply/round to avoid numerical weirdness...picking the first lowest plan also seems to work.
  • variety of other small bugs in costing
  • update join bug where the projections after a rearrangement lost expression id/nullability info. This was exposed by the changes above

@max-hoffman max-hoffman merged commit 63f9c46 into main Feb 20, 2024
7 checks passed
@max-hoffman max-hoffman deleted the max/fix-index-costing-bug branch February 20, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant