Fix DISTINCT over DECIMALS
#2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Feb 16, 2024
sql/expression/distinct.go
Outdated
| @@ -31,16 +33,36 @@ func (de *DistinctExpression) seenValue(ctx *sql.Context, value interface{}) (bo | |||
| de.dispose = dispose | |||
| } | |||
|
|
|||
| hash, err := hashstructure.Hash(value, nil) | |||
| // TODO: how to handle nil? | |||
There was a problem hiding this comment.
docstring might be helpful, I'm assuming nil doesn't hash so we need to keep a variable for it? Should the close function set seenNil back to false in case the expression is reused?
There was a problem hiding this comment.
Yep nil can't be hashed; I definitely need to set seenNil back to false in Dispose() method. Will fix!
added 2 commits
February 16, 2024 14:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was another place where we were using
hashstructurepackage, which does not hashdecimal.Decimaltypes correctly.Switched to
xxhashpackage, which is what we use everywhere else.Reusing solution from: #2279
This will fix 1 sqllogictest.