Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement random_bytes() #2365

Merged
merged 4 commits into from
Mar 4, 2024
Merged

implement random_bytes() #2365

merged 4 commits into from
Mar 4, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Mar 4, 2024

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a couple very minor comments.

Comment on lines 30 to 31
// RandomBytes returns the random_bytes of a string or binary content, either in bytes
// or characters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments look like they're copy/paste artifact from the length() function

sql/expression/function/random_bytes.go Outdated Show resolved Hide resolved
sql/expression/function/random_bytes_test.go Outdated Show resolved Hide resolved
skip bool
err *errors.Kind
}{
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) maybe another error test case where the length is of a varchar type or something.

@jycor jycor merged commit 6aeab27 into main Mar 4, 2024
7 checks passed
@jycor jycor deleted the james/rand branch March 4, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants