fix in-memory implementation of RenameTable to read from session #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
reviewed
Mar 15, 2024
enginetest/queries/script_queries.go
Outdated
| @@ -6182,6 +6182,34 @@ where | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| Name: "alter statements apply correctly", | |||
There was a problem hiding this comment.
Kind of a vague name, what specifically are you testing here? How is this not covered in TestAlterTable e.g.?
memory/table.go
Outdated
| @@ -1415,6 +1415,7 @@ func (t *Table) ModifyColumn(ctx *sql.Context, columnName string, column *sql.Co | |||
| } | |||
| } | |||
|
|
|||
| t.db.tables[t.name] = t | |||
There was a problem hiding this comment.
This is supposed to happen when the session is committed. Why isn't it? You have to fix that bug, not mess up the global state here.
added 2 commits
March 17, 2024 00:43
jycor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The in-memory implementation of RenameTable uses data from the BaseDatabase, instead of reading it from the session.
This is problematic when there are multiple alter statements.
Additonally, includes some small refactor so all functions are pointer receiver instead of a mix.
fixes #2396