Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dbName not being used in the example #2403

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix dbName not being used in the example #2403

merged 1 commit into from
Mar 22, 2024

Conversation

stalecu
Copy link
Contributor

@stalecu stalecu commented Mar 18, 2024

This PR makes sure that dbName in the example is actually being used, instead of having a hardcoded "mydb" in createTestDatabase.

fixes #2402

jycor
jycor approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jycor jycor merged commit d07852d into dolthub:main Mar 22, 2024
8 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent usage of variables in the example
3 participants
@stalecu @jycor @coffeegoddd