support Com_delete, Com_insert, Com_update status variables
#2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Apr 1, 2024
sql/core.go
Outdated
Comment on lines
768
to
778
| // TODO: goroutine for speed | ||
| if _, globalComDelete, ok := StatusVariables.GetGlobal(name); ok { | ||
| if v, isUint64 := globalComDelete.(uint64); isUint64 { | ||
| StatusVariables.SetGlobal(name, v+1) | ||
| } | ||
| } | ||
| if sessComDelete, err := ctx.GetStatusVariable(ctx, name); err == nil { | ||
| if v, isUint64 := sessComDelete.(uint64); isUint64 { | ||
| ctx.SetStatusVariable(ctx, name, v+1) | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we just go ahead and add it while we're in here? The tests may be racey then and need a little pause before checking var values. We could hold off and do a quick perf profile and see how big the difference is, but since this code needs to lock two mutexes, it's probably going to be worth it, especially in an environment with multiple clients and contention on the locks.
There was a problem hiding this comment.
Adding goroutines here:
#2430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: dolthub/dolt#7646