Roughest implementation of stored procedures #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Feb 19, 2021
| @@ -78,6 +79,7 @@ var OnceAfterDefault = []Rule{ | |||
| {"resolve_insert_rows", resolveInsertRows}, | |||
| {"apply_triggers", applyTriggers}, | |||
| {"apply_row_update_accumulators", applyUpdateAccumulators}, | |||
| {"apply_procedures", applyProcedures}, | |||
There was a problem hiding this comment.
Seems like in general you need to this come before the row update accumulator step (but I'm not sure how MySQL reports row update stats for CALL statements)
There was a problem hiding this comment.
So looking into this a bit more...wow MySQL does some strange stuff here. Basically for INSERT, UPDATE, & DELETE, it only looks at the last statement and returns that. However, if you have a SELECT anywhere, then that is returned instead. But if you have multiple SELECTs, then they are all returned. Testing around, it seems that not all MySQL clients even support multiple result sets from a query, so they just return the last SELECT, but others will return each one.
Hydrocharged
force-pushed
the
daylon/stored-procedures
branch
2 times, most recently
from
40821d7
to
95159c8
Compare
Hydrocharged
force-pushed
the
daylon/stored-procedures
branch
from
95159c8
to
ef1f9dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to go into detail regarding what doesn't work (a lot), but it's groundwork to iterate on.