sql/{plan,analyzer}: Cache subquery results when joining against a subquery. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Mar 1, 2021
| if i.cache != nil { | ||
| if err != nil { | ||
| if err == io.EOF { | ||
| i.parent.mutex.Lock() |
There was a problem hiding this comment.
This would be a little easier to read with fillCacheInParent method
sql/plan/cached_results.go
Outdated
| i.parent.cache = i.cache | ||
| i.parent.dispose = i.dispose | ||
| } else { | ||
| i.dispose() |
There was a problem hiding this comment.
i.cleanUp() for this repeated block?
| _, isJoin := parent.(plan.JoinNode) | ||
| _, isIndexedJoin := parent.(*plan.IndexedJoin) | ||
| if isJoin || isIndexedJoin { | ||
| sa, isSubqueryAlias := child.(*plan.SubqueryAlias) |
There was a problem hiding this comment.
This is going to waste memory unnecessarily if the subquery is the first table in the join and therefore unnecessary to cache. Maybe add a TODO to fix? (algorithm to determine this case doesn't map easily to one of the transform up methods, i don't think)
…achedResults nodes from join plans.
zachmu
reviewed
Mar 2, 2021
| } | ||
| } else if j, isIndexedJoin := parent.(*plan.IndexedJoin); isIndexedJoin { | ||
| if j.JoinType() == plan.JoinTypeRight { | ||
| return childNum == 1 |
There was a problem hiding this comment.
This is wrong -- indexed joins always put the primary table as the first table, even if it's a right join
…t child of indexed joins.
…y-alias-results-in-joins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.