Updates to SHOW TABLE STATUS #335
Conversation
enginetest/queries.go
Outdated
| }, | ||
| }, | ||
| { | ||
| Query: `SHOW TABLE SATUS FROM mydb LIKE 'othertable'`, |
sql/core.go
Outdated
| @@ -259,6 +259,10 @@ type StatisticsTable interface { | |||
| Table | |||
| // NumRows returns the unfiltered count of rows contained in the table | |||
| NumRows(*Context) (uint64, error) | |||
| // NextAutoIncrementValue returns the next autoincrement value for a table and 0 if autoincrement does not apply. | |||
| NextAutoIncrementValue(ctx *Context) (int64, error) | |||
There was a problem hiding this comment.
This should be on AutoIncrementTable (or use the existing interface, should work fine)
sql/parse/parse.go
Outdated
| case sqlparser.KeywordString(sqlparser.TABLE): | ||
| return parseShowTableStatus(ctx, query) | ||
| case "table status": | ||
| return parseShowTableStatus(ctx, s) |
There was a problem hiding this comment.
Use convert, not parse for these methods
sql/parse/parse.go
Outdated
| default: | ||
| return nil, errUnexpectedSyntax.New("one of: FROM, IN, LIKE or WHERE", clause) | ||
| db := s.Database | ||
| var node sql.Node = plan.NewShowTableStatus(ctx.GetCurrentDatabase()) |
There was a problem hiding this comment.
This is a weird way to express this. Set db to default to ctx.GetCurrentDatabase, then override it if set in the AST node. Then always set node = plan.NewShowTableStatus(db). Basically, keep the branching logic to the smallest possible unit of information in cases like this
sql/plan/showtablestatus.go
Outdated
|
|
||
| tables, err = db.GetTableNames(ctx) | ||
| db, err := s.Catalog.Database(dbName) |
There was a problem hiding this comment.
Implement sql.Databaser and set it in the analzyer, rather than getting it at runtime
sql/plan/showtablestatus.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| aiVal, err := st.NextAutoIncrementValue(ctx) |
There was a problem hiding this comment.
Like I mentioned earlier, move this out of StatisticsTable and conditionally set this if the table implements AutoIncrementTable
No description provided.