Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed procedure params not being used in INSERT/REPLACE values #354

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Fixed procedure params not being used in INSERT/REPLACE values #354

merged 1 commit into from
Apr 3, 2021

Conversation

Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Apr 2, 2021 •
edited
Loading

@Hydrocharged Hydrocharged requested a review from zachmu April 2, 2021 12:02
zachmu
zachmu approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably have the same problem for param substitution inside subqueries and unions, you should write some tests

sql/analyzer/stored_procedures.go Outdated Show resolved Hide resolved
sql/analyzer/stored_procedures.go Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit ab0cc5a into master Apr 3, 2021
@Hydrocharged Hydrocharged deleted the daylon/values-resolve branch April 3, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not use stored procedure with arguments
2 participants
@Hydrocharged @zachmu