server/handler.go: Use exposed mysql.Conn.Conn instead of trying to track it through Accept. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rack it through Accept.
reltuk
commented
Apr 27, 2021
server/handler.go
Outdated
| errChan <- ErrConnectionWasClosed.New() | ||
| return | ||
| case sockstate.Error: | ||
| errChan <- err | ||
| logrus.Warnf("Connection checker exiting, got err checking sockstate: %v", err) |
There was a problem hiding this comment.
We're changing the behavior here as well to just warn and shutdown the checking goroutine. This functionality is nice-to-have, but by no means critical.
zachmu
approved these changes
Apr 27, 2021
server/handler.go
Outdated
| errChan <- ErrConnectionWasClosed.New() | ||
| return | ||
| case sockstate.Error: | ||
| errChan <- err | ||
| logrus.Debugf("Connection checker exiting, got err checking sockstate: %v", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.