Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor nil check handling #395

Merged
merged 5 commits into from
Apr 30, 2021
Merged

Refactor nil check handling #395

merged 5 commits into from
Apr 30, 2021

Conversation

max-hoffman
Copy link
Contributor

nil responses won't throw check constraint errors anymore

@max-hoffman max-hoffman mentioned this pull request Apr 29, 2021
Merged
@max-hoffman max-hoffman requested a review from zachmu April 29, 2021 19:03
zachmu
zachmu approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, but could benefit from a couple helper methods

sql/core.go Outdated Show resolved Hide resolved
sql/expression/case.go Outdated Show resolved Hide resolved
sql/system_variables.go Outdated Show resolved Hide resolved
@max-hoffman max-hoffman merged commit 0d65e75 into master Apr 30, 2021
@max-hoffman max-hoffman deleted the max/check-null branch April 30, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-hoffman @zachmu