Vinai/json contains #401
Merged
Vinai/json contains #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinaiRachakonda
requested review from
Hydrocharged
and removed request for
Hydrocharged
Hydrocharged
approved these changes
May 4, 2021
| } | ||
|
|
||
| // FunctionName implements sql.FunctionExpression | ||
| func (j JSONContains) FunctionName() string { | ||
| return "json_contains" | ||
| } | ||
|
|
||
| func (j JSONContains) Resolved() bool { |
There was a problem hiding this comment.
All of these need to be pointer receivers. If you're checking that you're implementing an interface via a pointer (var _ sql.FunctionExpression = (*JSONContains)(nil) here) and returning a pointer from New, then all of your functions should be pointers as well.
There was a problem hiding this comment.
Totally my bad. Will be more cautious next time
| return []sql.Expression{j.JSONTarget, j.JSONCandidate} | ||
| } | ||
|
|
||
| func (j JSONContains) WithChildren(children ...sql.Expression) (sql.Expression, error) { |
There was a problem hiding this comment.
Check if the count is the same. If you sent out 3 expressions in Children, then you should have 3 here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the json_contains function