Transaction support #424
Merged
Transaction support #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as unused (used for async index creation, which we don't support at the moment)
…moved a spurious debug from a test
andy-wm-arthur
approved these changes
May 19, 2021
| // This is a bit odd, but because this setup doesn't interact with the engine.Query path, we need to do transaction | ||
| // management here, instead. If we don't, then any Query-based setup will wipe out our work by starting a new | ||
| // transaction without committing the work done so far. | ||
| // The secondary foo database doesn't have this problem because we don't mix and match query and non-query setup |
There was a problem hiding this comment.
I've wondered if we shouldn't refactor testdata to just query the harness
There was a problem hiding this comment.
The issue is that then we couldn't run the engine tests on read only database implementations, so it's worth some amount of futzing to support
There was a problem hiding this comment.
Actually now that I'm saying that, it's already not true, they have to implement sql.InsertableTable at a minimum already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: