Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/analyzer/optimization_rules.go: moveJoinConditionsToFilter: Fix small inaccuracy where computed topJoin could be wrong. #557

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Sep 17, 2021

This could result in the optimization pass adding the same Filter node to
multiple places in the join tree.

…mall inaccuracy where computed topJoin could be wrong.

This could result in the optimization pass adding the same Filter node to
multiple places in the join tree.
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reltuk reltuk merged commit fe3a822 into master Sep 21, 2021
@Hydrocharged Hydrocharged deleted the aaron/join-condition-to-filter-fix-topJoin branch December 8, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants