sql/analyzer: pushdown_filters: Avoid pushing down filters below Window nodes. #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow nodes. If a Filter is above a Window node, the Window node will be aggregating and computing projections based on the rows that it sees. It is not safe to push the filter below the Window node. The parser and analyzer currently work in concert (and must work in concert for Window results to be correct) to keep Filter nodes which do apply to the Window below the Window.
zachmu
approved these changes
Oct 25, 2021
sql/analyzer/pushdown.go
Outdated
| case *plan.Window: | ||
| // Windows operate across the rows they see and cannot have | ||
| // filters pushed below them. Instead, the step will be run | ||
| // again by the Transform function, starting at this ndoe. |
Hydrocharged
deleted the
aaron/analyzer-avoid-filter-pushdown-over-window
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Filter is above a Window node, the Window node will be aggregating and
computing projections based on the rows that it sees. It is not safe to push
the filter below the Window node.
The parser and analyzer currently work in concert (and must work in concert for
Window results to be correct) to keep Filter nodes which do apply to the Window
below the Window.